Port is now retrieved by AppScriptServlet#335
Port is now retrieved by AppScriptServlet#335echarles wants to merge 2 commits intoZEPL:masterfrom echarles:appscript
Conversation
|
what if I use grunt serve? will I be able to work on Zeppelin? |
|
@echarles Thanks for raising issue. While dev mode gives big value (code changes reflected on the fly, does not need to rebuild project every single change) in zeppelin-web development, I think it's worth to keep the feature. Is it possible to solve your problem with keeping dev mode support? |
|
@Leemoonsoo just pushed a change which keeps dev mode support. |
|
we use grunt serve for front end dev. this is really usefull because with the grunt serve we got live reload, a
|
|
@echarles Like @anthonycorbacho said, This PR Looks good to me! Thanks for contribution! |
|
LGTM to me, but please hold merging until #321 is merged. |
|
@echarles Zeppelin recently has moved to Apache and this repository will not accept update anymore. Could you recreate your pull-request to https://github.com/apache/incubator-zeppelin? |
The AppScriptServlet changes the content of app.js on the fly.
When I run vanilla zeppelin, I receive a blank page with a js error:
SyntaxError: syntax error function getPort(){return 8081} else if (location.protocol === 'https:' && (port...The changes simply removes the unneeded js code, leaving the server to the job for the port definition.